Skip to content

Fix command add_args#354

Merged
PearsonWhite merged 1 commit into
masterfrom
pwhite/command
Jul 19, 2026
Merged

Fix command add_args#354
PearsonWhite merged 1 commit into
masterfrom
pwhite/command

Conversation

@PearsonWhite

Copy link
Copy Markdown
Contributor

Add_args was comparing the flag to tuples when searching for existing args, thus failing to properly replace when on_duplicate="replace".

Add_args was comparing the flag to tuples when searching for existing
args, thus failing to properly replace when on_duplicate="replace".
@PearsonWhite PearsonWhite self-assigned this Jul 16, 2026
@PearsonWhite PearsonWhite added this to DST Jul 16, 2026
@PearsonWhite PearsonWhite added the ift IFT commitments label Jul 16, 2026
@PearsonWhite
PearsonWhite marked this pull request as ready for review July 16, 2026 13:14

@radiken radiken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AlbertoSoutullo AlbertoSoutullo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PearsonWhite
PearsonWhite merged commit a727f13 into master Jul 19, 2026
2 checks passed
@PearsonWhite
PearsonWhite deleted the pwhite/command branch July 19, 2026 23:59
@github-project-automation github-project-automation Bot moved this to Done in DST Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ift IFT commitments

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants